search

holidayextras / make-up

All of the checks for all of the linters.
3 stars 2 forks source link

Linting node_modules #21

Closed robhuzzey closed 9 years ago

robhuzzey commented 9 years ago

Looking at this.. if you run it in command line without any arguments, it lints all files (which is sometimes what you want) but it also had issue because this means it will lint node_modules directory too!

I would like to see either an exclude flag --exclude= or by default it excludes node_modules directory?

pmcnr-hx commented 9 years ago

ESLint default behaviour is to exclude node_modules. I can't think of any scenario where node_modules needs to be linted so it should be excluded by default and if by any reason the user wants to include it they can add it explicitly to the list of directories to lint.

philmeehan commented 9 years ago

It's not doing that for me. If I run node_modules/.bin/make-up

inside this repo https://github.com/holidayextras/plugin-cybersource

it only checks these files [ './Gruntfile.js', './index.js', './temp.js' ]

You sure you are running the latest release?

robhuzzey commented 9 years ago

@philmeehan silly question... but you do have a node_modules dir in there when you run it right?

robhuzzey commented 9 years ago

@philmeehan I see the issue now... it failed for me when I ran ./node_modules/.bin/make-up ./ but... when I run ./node_modules/.bin/make-up it defaults to only lint the files & no folders at the root.

@cameronviner that should solve your issue.