Closed jodiedoubleday closed 8 years ago
Tested this locally and worked as expected, nice touch making the readOnly a prop rather than hardcoded. :+1:
Taking review :two:
Comments addressed. The react a11y warnings are okay, i think these are solved by fixing the code editor on docs (generally thats not very accessible by nature) we may want to remove this functionality or make it better in the future.
ok with me now :+1:
What does this PR do? (please provide any background)
label
element. By removing the one from<input>
and surrounding and putting it before the stepper itself. This is better for usability purposes and styling.What tests does this PR have?
Checks a label is present when and ID is passed through
How can this be tested?
run
npm run docs
click view the stepper component and click on the label (nownumber of passengers
rather thanHELLO
) it should enter the input element (which is now NOT read-only by default)Screenshots / Screencast
What gif best describes how you feel about this work?
Reviewers
Review 1
Review 2 *
Review 3 (optional)
By adding a +1 you are confirming you have...
* for HX this review must be completed by an SE, SA or Project Guru