holidayextras / ui-toolkit

DEPRECATED - CSS & React components
http://tech.holidayextras.co.uk/ui-toolkit/
MIT License
14 stars 3 forks source link

HELLO - Is it me you're looking for? #120

Closed jodiedoubleday closed 8 years ago

jodiedoubleday commented 8 years ago

What does this PR do? (please provide any background)

Checks a label is present when and ID is passed through

How can this be tested?

run npm run docs click view the stepper component and click on the label (now number of passengers rather than HELLO) it should enter the input element (which is now NOT read-only by default)

Screenshots / Screencast

screen shot 2015-11-25 at 17 00 41

What gif best describes how you feel about this work?

HELLO


Review 1

Review 2 *

Review 3 (optional)

By adding a +1 you are confirming you have...

* for HX this review must be completed by an SE, SA or Project Guru

richardstevens commented 8 years ago

Tested this locally and worked as expected, nice touch making the readOnly a prop rather than hardcoded. :+1:

hxpaul commented 8 years ago

Taking review :two:

jodiedoubleday commented 8 years ago

Comments addressed. The react a11y warnings are okay, i think these are solved by fixing the code editor on docs (generally thats not very accessible by nature) we may want to remove this functionality or make it better in the future.

hxpaul commented 8 years ago

ok with me now :+1: