holidayextras / ui-toolkit

DEPRECATED - CSS & React components
http://tech.holidayextras.co.uk/ui-toolkit/
MIT License
14 stars 3 forks source link

Adding upload to S3 with Travis deploy #121

Closed andycastleuk closed 8 years ago

andycastleuk commented 8 years ago

What does this PR do? (please provide any background)

Enables deploying of the UIToolkit to an S3 bucket.

What tests does this PR have?

N/A

How can this be tested?

The first step is to get this merged. The CI should still function as normal, however when making a change to the package.json file. It should trigger a deploy (which won't actually do anything yet!).

What gif best describes how you feel about this work?

minon


Review 1

Review 2 *

Review 3 (optional)

By adding a +1 you are confirming you have...

* for HX this review must be completed by an SE, SA or Project Guru

Joezo commented 8 years ago

:+1: looks like it should work :)

hx-markterry commented 8 years ago

taken

hx-markterry commented 8 years ago

looking good, only one tiny comment, +1 if that gets fixed.