holidayextras / ui-toolkit

DEPRECATED - CSS & React components
http://tech.holidayextras.co.uk/ui-toolkit/
MIT License
14 stars 3 forks source link

Allow any value text to be passed to the stepper so we can control the value #122

Closed richardstevens closed 8 years ago

richardstevens commented 8 years ago

What does this PR do? (please provide any background)

This allows us to send a value of our own into the input, this allows us to use the props to correctly increment and decrement but then display the result of this how we would like.

What tests does this PR have?

Usual tests and linting, i have updated the stepper test to include the setting of the valueText prop

How can this be tested?

This cant be tested until the new wizard repo is also updated


Review 1

Review 2 *

Review 3 (optional)

By adding a +1 you are confirming you have...

* for HX this review must be completed by an SE, SA or Project Guru

hxpaul commented 8 years ago

Small recommended change but otherwise ok

elliottcrush commented 8 years ago

All good, works a treat.

hxpaul commented 8 years ago

review :one: all good now :+1: