holidayextras / ui-toolkit

DEPRECATED - CSS & React components
http://tech.holidayextras.co.uk/ui-toolkit/
MIT License
14 stars 3 forks source link

Update to latest version of babel and remove node version #123

Closed jodiedoubleday closed 8 years ago

jodiedoubleday commented 8 years ago

What does this PR do? (please provide any background)

None

How can this be tested?

Delete the UIToolkit from you machine then clone it again. If you don't do this it will unfortunately fail to build. npm install npm run docs check the docs looks as good and work as well as they do on ui-toolkit.com You will have no console errors

Screenshots / Screencast

None

What gif best describes how you feel about this work?

Babelfish


Review 1

Review 2 *

Review 3 (optional)

By adding a +1 you are confirming you have...

* for HX this review must be completed by an SE, SA or Project Guru

elliottcrush commented 8 years ago

Had some issues installing, 'turning it off and on again' seemed to work though. Looks good :+1:

Joezo commented 8 years ago

Reviewing this

Joezo commented 8 years ago

Followed all the steps and still got an error when building :(

Running "shell:docsBuild" (shell) task

> ui-toolkit-docs@0.0.0 build /Users/joe.warren/repos/ui-toolkit/docs
> ./scripts/build.sh

Building docs
Error: Cannot find module 'babel-runtime/helpers/to-consumable-array' from '/Users/joe.warren/repos/ui-toolkit/node_modules/react-a11y/dist'
hxpaul commented 8 years ago

you have conflicts here

hxpaul commented 8 years ago

Also I get the same error as Joe when trying to build

Cannot find module 'babel-runtime/helpers/to-consumable-array' from '/Users/paul.clarke/work/ui-toolkit/node_modules/react-a11y/dist'

error in the ui-toolkit-docs I think rather than the ui-toolkit