Closed jackdclark closed 8 years ago
We don't render a temperature when it's 0 because JS evaluates 0 as falsy
0
Added a regression test for this in weather-test.jsx
weather-test.jsx
npm run docs & check http://localhost:4000/#weather, I've conveniently added an example with 0 to see it working
npm run docs
Review 1
Review 2 *
Review 3 (optional)
By adding a +1 you are confirming you have...
* for HX this review must be completed by an SE, SA or Project Guru
Taking :two:
Looking good! :+1:
I suppose so. :+1:
What does this PR do? (please provide any background)
We don't render a temperature when it's
0
because JS evaluates0
as falsyWhat tests does this PR have?
Added a regression test for this in
weather-test.jsx
How can this be tested?
npm run docs
& check http://localhost:4000/#weather, I've conveniently added an example with0
to see it workingScreenshots / Screencast
What gif best describes how you feel about this work?
Reviewers
Review 1
Review 2 *
Review 3 (optional)
By adding a +1 you are confirming you have...
* for HX this review must be completed by an SE, SA or Project Guru