holidayextras / ui-toolkit

DEPRECATED - CSS & React components
http://tech.holidayextras.co.uk/ui-toolkit/
MIT License
14 stars 3 forks source link

HEHA-315 Weather: accept 0 as a temperature #131

Closed jackdclark closed 8 years ago

jackdclark commented 8 years ago

What does this PR do? (please provide any background)

We don't render a temperature when it's 0 because JS evaluates 0 as falsy

What tests does this PR have?

Added a regression test for this in weather-test.jsx

How can this be tested?

npm run docs & check http://localhost:4000/#weather, I've conveniently added an example with 0 to see it working

Screenshots / Screencast

screen shot 2016-02-16 at 15 47 19

What gif best describes how you feel about this work?

freezing


Review 1

Review 2 *

Review 3 (optional)

By adding a +1 you are confirming you have...

* for HX this review must be completed by an SE, SA or Project Guru

rahulpatel commented 8 years ago

Taking :two:

rahulpatel commented 8 years ago

Looking good! :+1:

elliottcrush commented 8 years ago

I suppose so. :+1: