holidayextras / ui-toolkit

DEPRECATED - CSS & React components
http://tech.holidayextras.co.uk/ui-toolkit/
MIT License
14 stars 3 forks source link

fixed annoying version check #133

Closed hx-markterry closed 8 years ago

hx-markterry commented 8 years ago

What does this PR do? (please provide any background)

When you install the ui-toolkit as a dependancy you receive the following warning:

npm WARN engine ui-toolkit@0.28.1: wanted: {"node":">0.10 <0.12","npm":"~2.14.8"} (current: {"node":"0.12.9","npm":"2.14.9"})

This change allows node 0.12 to be used without warning.

What tests does this PR have?

No tests as its just a tooling change.

How can this be tested?

Change your package.json to use this branch rather than a set version and you should not see the above version when you npm install.

Screenshots / Screencast

What gif best describes how you feel about this work?

giphy


Review 1

Review 2 *

Review 3 (optional)

By adding a +1 you are confirming you have...

* for HX this review must be completed by an SE, SA or Project Guru

elliottcrush commented 8 years ago

:mag:

elliottcrush commented 8 years ago

npm linked to the toolkit inside another repo and the warning has gone. :+1:

jodiedoubleday commented 8 years ago

error gone :shipit: