holidayextras / ui-toolkit

DEPRECATED - CSS & React components
http://tech.holidayextras.co.uk/ui-toolkit/
MIT License
14 stars 3 forks source link

Countdown component same day behaves differently #138

Open robhuzzey opened 8 years ago

robhuzzey commented 8 years ago

Looking at https://github.com/holidayextras/ui-toolkit/blob/master/src/components/countdown/lib/countdown.js#L49-L51 it seems that when we reach "same day" we behave differently by assuming we haven't passed in a time (moment.duration() defaults to same day at midnight).

Can we adjust this so it uses the time as well so we can do until=2016-03-24T12:00 for example.