holidayextras / ui-toolkit

DEPRECATED - CSS & React components
http://tech.holidayextras.co.uk/ui-toolkit/
MIT License
14 stars 3 forks source link

Button dropdown named branch wrong #141

Closed reecemillsom closed 8 years ago

reecemillsom commented 8 years ago

What does this PR do? (please provide any background)

This PR adds a button dropdown into the ui-toolkit as well as a compiler of sass for short breaks.

What tests does this PR have?

Unit tests. Run npm test

How can this be tested?

• Checkout my branch in ui-toolkit. • npm run docs - browser page will open automatically • On right hand side should see Button Dropdown under molecules section • Click this and make sure that the Button looks good and the options are nice :).

•If when you follow these steps and styles don't look write run grunt build

Screenshots / Screencast

http://grab.by/PFpo

What gif best describes how you feel about this work?


Review 1

Review 2 *

Review 3 (optional)

By adding a +1 you are confirming you have...

* for HX this review must be completed by an SE, SA or Project Guru

pseudosmart commented 8 years ago

3️⃣

jodiedoubleday commented 8 years ago

Taking :v:

reecemillsom commented 8 years ago

Going to remove SASS compiler and push work back up

reecemillsom commented 8 years ago

@jodiedoubleday sass compiler stuff removed :)

GeorgeF72 commented 8 years ago

1️⃣

jodiedoubleday commented 8 years ago

all good 💃

GeorgeF72 commented 8 years ago

looking good 👍

pseudosmart commented 8 years ago

I like :shipit: