holidayextras / ui-toolkit

DEPRECATED - CSS & React components
http://tech.holidayextras.co.uk/ui-toolkit/
MIT License
14 stars 3 forks source link

CON-1740 add a target attribute to image component #143

Closed djbeaumont closed 8 years ago

djbeaumont commented 8 years ago

What does this PR do? (please provide any background)

Adds a target attribute to the image component. This will allow us to have tile header images that when clicked on show a page in a new tab. This allows us to convert the static product tiles in TripApp to React.

What tests does this PR have?

New unit tests.

How can this be tested?


Review 1

Review 2

Review 3

By adding a +1 you are confirming you have...

ghost commented 8 years ago

@djbeaumont, thanks for your PR! By analyzing the blame information on this pull request, we identified @jodiedoubleday, @jackdcrawford and @robhuzzey to be potential reviewers

h0rhay commented 8 years ago

taking 2️⃣

h0rhay commented 8 years ago

Yup, works for me, nice work 👍

jodiedoubleday commented 8 years ago

Yup all good

Arditc commented 8 years ago

Good job! :) 👍