Closed djbeaumont closed 8 years ago
@djbeaumont, thanks for your PR! By analyzing the blame information on this pull request, we identified @jodiedoubleday, @jackdcrawford and @robhuzzey to be potential reviewers
taking 2️⃣
Yup, works for me, nice work 👍
Yup all good
Good job! :) 👍
What does this PR do? (please provide any background)
Adds a target attribute to the image component. This will allow us to have tile header images that when clicked on show a page in a new tab. This allows us to convert the static product tiles in TripApp to React.
What tests does this PR have?
New unit tests.
How can this be tested?
CON-1740-2
on TripAppnpm install
to get the version of ui-toolkit from this PRcd node_modules/@holidayextras/ui-toolkit && npm install && npm run build
cd -
npm start
Screenshots / Screencast
What gif best describes how you feel about this work?
Reviewers
Review 1
Review 2
Review 3
By adding a +1 you are confirming you have...