holidayextras / ui-toolkit

DEPRECATED - CSS & React components
http://tech.holidayextras.co.uk/ui-toolkit/
MIT License
14 stars 3 forks source link

APP-269 - Allowing the use of spread for the button component #148

Closed cameronviner closed 8 years ago

cameronviner commented 8 years ago

What does this PR do? (please provide any background)

This PR changes the button component so that you can pass in any prop and it will apply it to the button.

What tests does this PR have?

A new tests to cover adding a unspecified prop to the button

How can this be tested?

Pull the branch down and check the buttons still look the same as live. click the show code section underneath a button and add the following code to to a button:

onMouseOver={function(){alert('Hello');}}

Then mouse over the button you should see an alert appear.

Screenshots / Screencast

What gif best describes how you feel about this work?


Review 1

Review 2

Review 3

By adding a +1 you are confirming you have...

hxtomprice commented 8 years ago

Taken

hxtomprice commented 8 years ago

:+1: