holidayextras / ui-toolkit

DEPRECATED - CSS & React components
http://tech.holidayextras.co.uk/ui-toolkit/
MIT License
14 stars 3 forks source link

Add fallback for any apps still using handleClick #150

Closed dancork closed 8 years ago

dancork commented 8 years ago

What does this PR do? (please provide any background)

What tests does this PR have?

Add test for onClick and regression test for handleClick.

How can this be tested?

Fireup any tripapp using master (local, staging or production) Make a carpark search for LGW and on availability select a non-flexible product No upsell modal will fire

On your local machine pull this branch On your local tripapp npm link your local ui-toolkit ( probably npm link ../ui-toolkit ) Fire up tripapp and do the same search. An upsell modal should now fire

Screenshots / Screencast

What gif best describes how you feel about this work?


Review 1

Review 2

Review 3

By adding a +1 you are confirming you have...

cameronviner commented 8 years ago

Taking Review

cameronviner commented 8 years ago

Looks good to me 👍

rahulpatel commented 8 years ago

Nice! 👍 ✌️