Convert React.createClass to es2015 classes

holidayextras / ui-toolkit

DEPRECATED - CSS & React components

http://tech.holidayextras.co.uk/ui-toolkit/

MIT License

14 stars 3 forks source link

Convert React.createClass to es2015 classes #166

Closed djbeaumont closed 6 years ago

djbeaumont commented 6 years ago

This PR removes a mixin to flatten data attributes as mixins aren't supported in React es2015 classes. A couple of components have also been converted to functional components. There's now just ~4 components plus some documentation to make compatibile with React 16.

To test:

Check the test suite passes
Run the docs site with npm run docs
Check that the helper function will be transpiled by the npm run build script

hxpaul commented 6 years ago

finding it hard to test "in situ" in tripapp as I guess build is run on pre-publish to npm so can't easily install it from this branch... trying cd ./node_modules/\@holidayextras/ui-toolkit/ && npm run build from tripapp

djbeaumont commented 6 years ago

I've fixed the build issue and have tested this out locally against tripapp by copying the dist files in place:

npm run build
cd ../tripapp
rm -rf node_modules/@holidayextras/ui-toolkit/dist
cp -R ../ui-toolkit/dist node_modules/@holidayextras/ui-toolkit/