search

holiman / goevmlab

Evm laboratory
GNU Lesser General Public License v3.0
226 stars 42 forks source link

`revme` performance regression #160

Open holiman opened 3 weeks ago

holiman commented 3 weeks ago

For some reason, revm is super slow now, 10x slower than it used to be. 

INFO [06-05|11:19:12.946] Stats gethbatch-0                        execSpeed=32.7ms  longest=440.665257ms count=935
INFO [06-05|11:19:12.946] Stats eelsbatch-0                        execSpeed=950.5ms longest=6.400992834s count=35
INFO [06-05|11:19:12.946] Stats nethbatch-0                        execSpeed=36.8ms  longest=2.215896613s count=815
INFO [06-05|11:19:12.946] Stats besubatch-0                        execSpeed=26.8ms  longest=2.438839096s count=909
INFO [06-05|11:19:12.946] Stats erigonbatch-0                      execSpeed=64.8ms  longest=3.793626718s count=402
INFO [06-05|11:19:12.946] Stats nimbus-0                           execSpeed=336.4ms longest=2.510137747s count=108
INFO [06-05|11:19:12.946] Stats evmone-0                           execSpeed=48.6ms  longest=1.495841309s count=872
INFO [06-05|11:19:12.946] Stats revm-0                             execSpeed=587.7ms longest=3.731686224s count=67

cc @rakita

rakita commented 3 weeks ago

Did you build it in release? We are checking with valgrind for perf degredations: https://github.com/bluealloy/revm/pull/1467#issuecomment-2140860061

rakita commented 2 weeks ago

@holiman did you have time to test this?

namiloh commented 2 weeks ago

This is how I build it: https://github.com/holiman/goevmlab/blob/master/docker/Dockerfile#L96

The regression might not be "evm gas per second", might just be an added few milliseconds during startup