Parser/support non ascii letters in identifiers - Githubissues

holistics / dbml

Database Markup Language (DBML), designed to define and document database structures

https://dbml.org

Apache License 2.0

2.9k stars 170 forks source link

Parser/support non ascii letters in identifiers #521

Closed Huy-DNA closed 8 months ago

Huy-DNA commented 9 months ago

Summary

Support non-ascii letters (Arabic, Kanji, etc.) in identifiers
No longer quote identifiers that contain non-ascii letters // TODO: Improve autosuggestion for identifiers that start with a non-ascii letter, as the user has to manually CTRL + Space for the suggestion to trigger

Issue

(issue link here)

Lasting Changes (Technical)

The character check in lexer.
The suggestion util addQuotesIfNeeded

Checklist

Please check directly on the box once each of these are done

[X] Documentation (if necessary)
[X] Tests (integration test/unit test)
[ ] Integration Tests Passed
[ ] Code Review