holium / ballot

An Urbit app for voting on proposals and polls.
MIT License
2 stars 0 forks source link

Promoting to admin in Groups doesn't update participant record in Ballot #70

Closed drunkplato closed 2 years ago

drunkplato commented 2 years ago

I have a member ~dev and I promote him to the admin role in Groups. This does not seem to update the participant record for ~dev in Ballot.

subnet-arts commented 2 years ago

how did you promote it to admin?

subnet-arts commented 2 years ago

save-participant with data.role = 'admin'?

subnet-arts commented 2 years ago

this doesn't even seem possible. no save-participant action righ tnow.

drunkplato commented 2 years ago

Promote via Groups app in Groups Settings

image
subnet-arts commented 2 years ago

fixed.

%initial action on groups is called when promoting/demoting a member. modified the %initial action handler in ballot to ensure the tags are read in to ensure role is set properly on each member.

drunkplato commented 2 years ago

Okay, so this has a new error now. When doing this through groups.

For one, when ~zod promotes ~bus to admin, it actually makes ~bus rejoin the group from the booth dropdown menu. It looks like ~bus is set to enlisted.

image

It also seems to reset my booth settings as before I did the promote test case, my booth was restricted to creating proposals as only admin, but after this promotion test case, I see it reset the defaults. It even reset my duration and support values in the booth.

Here is the log from ~zod

image

After all of this, it doesn't appear the participant ~bus has a role='admin' in the group

drunkplato commented 2 years ago

Fixed