'Total Force' Scalar displays sum of velocity differences instead of forces (Burgers' Equation)

holl- / PDE-Control

Code for the ICLR 2020 paper "Learning to Control PDEs"

MIT License

29 stars 8 forks source link

'Total Force' Scalar displays sum of velocity differences instead of forces (Burgers' Equation) #1

Closed Sh0cktr4p closed 3 years ago

Sh0cktr4p commented 3 years ago

More of a minor detail, but I think in the total_force_loss method of the BurgersPDE class, self.scalars['Total Force'] should be set to l1 / self.dt instead of just l1. This way, the values are independent of the time step size and comparable to the values of the FieldEffect used to generate the ground truth.

holl- commented 3 years ago

You're correct. However, since dt is just a constant in these experiments, it wouldn't affect the training or results.