search

hollance / BlazeFace-PyTorch

The BlazeFace face detector model implemented in PyTorch
Other
430 stars 91 forks source link

Intersection max_xy calculation correct? #17

Closed kapsyst closed 1 year ago

kapsyst commented 1 year ago

https://github.com/hollance/BlazeFace-PyTorch/blob/852bfd8e3d44ed6775761105bdcead4ef389a538/blazeface.py#L450

I may be reading it wrong, but are the lines used to calculate max_xy using the box dimensions, when they should be using the boxes max x/y coordinates?

A box is defined as [min_x, min_y, dim_x, dim_y], is it not?

kapsyst commented 1 year ago

My bad, I was confusing decoded boxes with raw boxes: https://github.com/hollance/BlazeFace-PyTorch/blob/852bfd8e3d44ed6775761105bdcead4ef389a538/blazeface.py#L365 Makes sense now!