search

holland-backup / holland

Holland Backup Manager
http://hollandbackup.org
Other
152 stars 49 forks source link

Mysqldump dry run #254

Closed soulen3 closed 5 years ago

soulen3 commented 5 years ago

Remove unused code and mock subprocess.popen call so mysqldump doesn't run during dry-run

soulen3 commented 5 years ago

Fixes #251

nwbreneman commented 5 years ago

Looks like some linting issues in plugins/holland.backup.mysqldump/holland/backup/mysqldump/mock/__init__.py at least, and also reveals that only the last plugin pylint check has to pass in order for Travis to pass that job. I'll open & assign an issue for that; I think adding a small bash script to do the pylint checks at this point is best if you agree.

soulen3 commented 5 years ago

That was a good catch. I forgot to run pylint and just assumed it would be picked up in testing