search

holland-backup / holland

Holland Backup Manager
http://hollandbackup.org
Other
152 stars 49 forks source link

kill signal not passed to split #285

Closed mikegriffin closed 5 years ago

mikegriffin commented 5 years ago

In #274 the split option was added to compression. Attempting to kill a holland process, I saw that the compressor (pigz in this case) died, as did holland, but split seems to not have received the signal and had to be killed manually.

soulen3 commented 5 years ago

I'm not sure what the issue is yet, but I've only been able to reproduce it on Centos 6 using python 2.6.

soulen3 commented 5 years ago

This is definitely an issue with the subprocess module for python2.6. There's a subprocess32 module available that fixes this, but it's not packages in EPEL6

soulen3 commented 5 years ago

This is fixed or disabled in version 1.1.15. For python 2, if the subprocess32 module is available holland will use that. If it's not available, Holland will disable the split command for python 2.6