soulen3
commented
5 years ago I hasn't able to reproduce this issue. Can you please provide more information about your environment? The Holland version, OS distribution, and python versions?
[root@c544365cc642 /]# psql --version
psql (PostgreSQL) 11.3
[root@c544365cc642 /]# holland bk postgres
Holland 1.1.16 started with pid 100
--- Starting backup run ---
Could not load backupset 'postgres': Config file not found: "/etc/holland/backupsets/postgres.conf".
--- Ending backup run ---
[root@c544365cc642 /]# psql --version
psql (PostgreSQL) 11.3
[root@c544365cc642 /]# holland bk pgdump
Holland 1.1.16 started with pid 103
--- Starting backup run ---
Creating backup path /var/spool/holland/pgdump/20190529_165410
Server version 11.3
Found databases: postgres
DB postgres size 7.51MB
Estimated Backup Size: 7.51MB
Using Historic Space Estimate: Checking for information in /var/spool/holland/pgdump/newest/backup.conf
Last backup used 1.73KB
Adjusting estimated size to last backup total * 1.1: 1.90KB
Starting backup[pgdump/20190529_165410] via plugin pgdump
Ignore compression method, since custom format is in use.
pg_dumpall -g > /var/spool/holland/pgdump/20190529_165410/data/global.sql
pg_dump --compress 1 --format custom postgres > /var/spool/holland/pgdump/20190529_165410/data/postgres.dump
Final on-disk backup size 1.73KB
0.02% of estimated size 7.51MB
Backup completed in 0.85 seconds
Purged pgdump/20190529_165137
1 backups purged
Released lock /etc/holland/backupsets/pgdump.conf
--- Ending backup run ---
If use Postgresql 11+ with pgdump plugin you can get error:
Version comparison going here: https://github.com/holland-backup/holland/blob/master/plugins/holland.backup.pgdump/holland/backup/pgdump/base.py#L197
I think it is correct to do so:
if float(VER) >= 8.4:It works for me.