search

holland-backup / holland

Holland Backup Manager
http://hollandbackup.org
Other
152 stars 49 forks source link

holland-mysqldump plugin is not aware of ssl options #300

Closed thederekotto closed 4 years ago

thederekotto commented 4 years ago

I ran into this issue after the most recent updates to the mysql-client packages on Ubuntu 16.04.2 LTS. MySQL is now defaulting to attempting SSL connections on all client connections, and the holland-mysqldump plugin does not provide a method to disable ssl. The errors show up as follows:

`Holland 1.0.12 started with pid 12966
--- Starting dry run ---
Creating backup path /var/lib/mysqlbackup/default/20191119_114224
Estimating size of mysqldump backup
Failed to estimate backup size
[2026] SSL connection error: error:00000001:lib(0):func(0):reason(1)
Backup failed after 0.02 seconds
Backup failed: MySQL Error [2026] SSL connection error: error:00000001:lib(0):func(0):reason(1)
--- Ending dry run ---
`
After setting ssl-mode=DISABLED in /root/.my.cnf, the error shows that the holland-mysqldump plugin is unaware of the ssl-mode parameter:

`Holland 1.0.12 started with pid 7054
--- Starting dry run ---
Creating backup path /var/lib/mysqlbackup/default/20191119_111333
Skipping unknown parameter ssl-mode
Estimating size of mysqldump backup
Failed to estimate backup size
[2026] SSL connection error: error:00000001:lib(0):func(0):reason(1)
Backup failed after 0.02 seconds
Backup failed: MySQL Error [2026] SSL connection error: error:00000001:lib(0):func(0):reason(1)
--- Ending dry run ---
`
Trying to set the value in the 'additional-arguments' parameter for the mysqldump provider also seems to be ignored. Setting the older 'ssl=0' also fails, but doesn't produce an error:

`Holland 1.0.12 started with pid 13110
--- Starting dry run ---
Creating backup path /var/lib/mysqlbackup/default/20191119_114305
Estimating size of mysqldump backup
Failed to estimate backup size
[2026] SSL connection error: error:00000001:lib(0):func(0):reason(1)
Backup failed after 0.03 seconds
Backup failed: MySQL Error [2026] SSL connection error: error:00000001:lib(0):func(0):reason(1)
--- Ending dry run ---
`
`:~# dpkg -l |grep mysql
rc  holland-mysqldump                  1.0.10-2                                   all          Holland MySQL Dump Backup Provider Plugin
ii  libmysqlclient20:amd64             5.7.28-0ubuntu0.16.04.2                    amd64        MySQL database client library
ii  mysql-client                       5.7.28-0ubuntu0.16.04.2                    all          MySQL database client (metapackage depending on the latest version)
ii  mysql-client-5.7                   5.7.28-0ubuntu0.16.04.2                    amd64        MySQL database client binaries
ii  mysql-client-core-5.7              5.7.28-0ubuntu0.16.04.2                    amd64        MySQL database core client binaries
ii  mysql-common                       5.7.28-0ubuntu0.16.04.2                    all          MySQL database common files, e.g. /etc/mysql/my.cnf
ii  php7.0-mysql                       7.0.33-0ubuntu0.16.04.7                    amd64        MySQL module for PHP
ii  python-mysqldb                     1.3.7-1build2                              amd64        Python interface to MySQL
root@server-02:~# dpkg -l |grep holland
rc  holland                            1.0.10-2                                   all          pluggable backup manager
rc  holland-mysqldump                  1.0.10-2                                   all          Holland MySQL Dump Backup Provider Plugin
`
soulen3 commented 4 years ago

Thanks for reporting this. I wasn't able to reproduce this, and Holland should be using the SSL option if set in the my.cnf file.