holland-backup / holland

Holland Backup Manager
http://hollandbackup.org
Other
152 stars 49 forks source link

Failure to execute on debian based systems #313

Closed TaiSHiNet closed 4 years ago

TaiSHiNet commented 4 years ago

Systems tested:

Package versions:

Output:


Holland 1.2.2 started with pid 6338
--- Starting dry run ---
Creating backup path /var/spool/holland/default/20200914_103628
Backup failed: Could not find dependency 'The 'python3-pymysql' distribution was not found and is required by holland.lib.mysql'
--- Ending dry run ---```

Also, python3-pymysql stopped being a dependency in the debian package (which led to finding this issue). Previous working version was `1.2.1-0`
soulen3 commented 4 years ago

This is expected behavior, and is mostly due to my lack on experience with Debain packaging.

This is documented in the install instructions https://hollandbackup.org/INSTALL.html

TaiSHiNet commented 4 years ago

@soulen3 the packages are installed (as mentioned in the guide) yet holland is complaining they aren't. This was working on previous version.

soulen3 commented 4 years ago

I'm not really sure what would have caused this. There weren't any changes to the holland.lib.mysql module between 1.2.1 and 1.2.2. This doesn't sound like an issue with the deb package, as that hasn't change and holland is installed.

soulen3 commented 4 years ago

I'm not sure what happened yet, but a work around is to edit /usr/lib/python3/dist-packages/holland.lib.mysql-1.2.2.egg-info/requires.txt

Change python3-pymysql to pymysql

TaiSHiNet commented 4 years ago

Workaround works around perfectly! Thanks!

soulen3 commented 4 years ago

So it was an issue in the deb. I've corrected it, and created a new release for 1.2.2. Please let me know if you're still having problems with 1.2.2-1.

Thanks for reporting this error.

TaiSHiNet commented 4 years ago

Perfect! Tested:

Everything works as expected, thanks a lot for the quick fix!