NOAA website changes broke lib/site/Geo/WeatherNOAA.pm and get_weather

hollie / misterhouse

Perl open source home automation program. It's fun, it's free, and it's entirely geeky.

243 stars 130 forks source link

NOAA website changes broke lib/site/Geo/WeatherNOAA.pm and get_weather #631

Closed marcmerlin closed 7 years ago

marcmerlin commented 8 years ago

gargamel:/var/local/src/misterhouse# mh/bin/get_weather -zone "SAN JOSE" -city "SAN JOSE" -state CA

Getting the current weather for SAN JOSE, CA Getting the forecast for SAN JOSE, CA

Current conditions: No data available

The forecast is As of :

Sadly, having a quick look at lib/site/Geo/WeatherNOAA.pm is not encouraging. Not knowing what the old page (that's now a redirect) looks like, it's hard to tell if it's gone altogether, or whether it's hiding under another URL and the fix is easy-ish.

marcmerlin commented 7 years ago

https://github.com/hollie/misterhouse/pull/629 (and its cleaned up replacement) make this work again, but the syntax of what you should query, has changed. mh/bin/get_weather -zone MTR -city "SAN JOSE" -state CA

klier commented 7 years ago

This looks fixed to me.

marcmerlin commented 7 years ago

It is indeed fixed, thanks.

ghost commented 7 years ago

Note that the NOAA has shutdown that (new, different, fixed) site, so any fixes based ont hat site are again broken: "The site which previously served that data has been shut down. Here is a link where you can get similar data: http://forecast.weather.gov/product.php?site=RAH&issuedby=RAH&product=RWR&format=txt&version=1&glossary=0. Let me know if you have any questions."