Closed valfirst closed 5 years ago
I'm hesitant to have any changes to the com.machinepublishers.glass.ui.monocle classes. Those are Open JDK classes that were removed from the standard JRE dist at some point and so they're copied here. A few changes have been made out of necessity but mostly they've been unaltered to make diffing easy to pull in latest Open JDK Monocle updates.
Otherwise looks good! Much nicer and thanks too for upgrading Selenium. Let me know what you think on backing out Monocle changes.
@hollingsworthd sorry, I wasn't aware of Monocle classes nature, and I'm agree that they should be kept unchanged as much as possible. I've reviewed and excluded Monocle classes from the changeset.
Looks good. Thanks a lot!
Thank you for contributing to this project!
If you haven't already done so, please agree to the Contributor's License Agreement: https://github.com/MachinePublishers/jBrowserDriver/blob/master/CLA-rev2-digital.txt
You can edit that file to add your digital signature to the bottom.