search

hollowaykeanho / Upscaler

A consolidation of various compiled open-source AI image/video upscaling product for a working CLI friendly image and video upscaling program.
BSD 3-Clause "New" or "Revised" License
252 stars 20 forks source link

Windows Has VC C++ Dependency #24

Closed JeanShuralyov closed 1 year ago

JeanShuralyov commented 1 year ago

Description

Please provide a short description of what you have encountered below.

On a plain Windows startup, one has to install VC C++ dependency in order to use the Upscaler. This is not documented as no one experience this beforehand.

Expected Behavior

Please specify the expected behavior of your usage below.

The VC C++ dependency is documented.

Current Behavior

Please specify the current behavior of software below.

VC C++ dependency is not documented.

Steps to Reproduce (COMPULSORY)

Please specify all the steps required to re-produce the problem.
  1. Buy a new laptop.
  2. Download the upscaler.
  3. Run tests/benchmark.cmd. An error occured stating MSVCP110D.dll or something from the package is missing.

Attachments

Please drag and drop the necessary data files (e.g. screenshot, logs, etc)
below.
hollowaykeanho commented 1 year ago

Acknowledged. You know what to do.

hollowaykeanho commented 1 year ago

patch 86e2c158f4b5913c5dfdb987d9044e00426b8879 accepted. Merging back to main.

hollowaykeanho commented 1 year ago

Patching received. Pending release.

JeanShuralyov commented 1 year ago

Wow, you're fast.

hollowaykeanho commented 1 year ago

Released.