search

hollowaykeanho / Upscaler

A consolidation of various compiled open-source AI image/video upscaling product for a working CLI friendly image and video upscaling program.
BSD 3-Clause "New" or "Revised" License
281 stars 23 forks source link

New Feature - Windows Support #4

Closed Joly0 closed 1 year ago

Joly0 commented 1 year ago

Hey, just wanted to let you know, that i am working on the windows part of this. I havent forked the project yet, but will do once i am finished. So far everything seems to be working, though starting powershell from the batch file with the arguments and everything correct gave me some headache, aswell as some other things. But i am quite sure, i will be done soon and hopefully have everything working by then.

But i wanted to know 2 things:

  1. I havent signed my commit ever, so i dont know, how this works, could you please explain this? And why you want this? It feels like it makes i way harder for people to contribute to this project although its quite cool.
  2. I saw you have your license information in every file, should i add something similar to files from me aswell? I would just copy/paste yours but replace your name with mine?
hollowaykeanho commented 1 year ago

What about the signing? Wasnt this an issue?

I will sign on behalf using my key.

Appearently on GitHub: Each owner signs his/her own repository when accepting patches. They are already signed and on stand-by. The whole idea of pull request is quite silly for me but it's quite encouraging new generations of developers with the gamifications. I won't mind supporting.

The pull request is for your GitHub profile badges attribution. =)

hollowaykeanho commented 1 year ago

Tada: https://github.com/hollowaykeanho/Upscaler/releases/tag/0.6.0

Thanks for making it happens. We can close the ticket now. I'll open the discussion tab so that we can chit-chat over there. =)

Joly0 commented 1 year ago

Nice, finally. Took some time, but i guess it was worth it in the end. Happy to see this released now :D

hollowaykeanho commented 1 year ago

Happily closing the ticket now.