hollowaykeanho / Upscaler

A consolidation of various compiled open-source AI image/video upscaling product for a working CLI friendly image and video upscaling program.
BSD 3-Clause "New" or "Revised" License
252 stars 20 forks source link

Find a way to sign Windows' Binary and the PowerShell script #6

Closed hollowaykeanho closed 1 year ago

hollowaykeanho commented 1 year ago

Description

Please provide a short description of what feature you're looking forward to
add into the existing repository below. Please include the story behind your
idea as well to give a better visualization of your idea.

Windows environment is too risky to operate with an unsigned binaries and scripts. Manual GPG verification is out of the list because it's complicated and will require one more dependency.

Need to explore features like:

sudo apt-get install osslsigncode

osslsigncode sign -pkcs12 "/mnt/c/path/to/certificate.p12" -pass "certificate password" -n "My Application Name" -i "https://www.mywebsite.com" -t "http://timestamp.comodoca.com/authenticode" -in "/mnt/c/path/to/executable.exe" -out "/mnt/c/path/to/executable.exe"

And find out any good source of trusted certificate (instead of paying MYR1200 per 3-year cert).

Expected Behavior

Please specify the expected behavior of your requested feature. Some great and
helpful pointers are your expected interface (e.g. command patterns, simple
sketches of the user interface, etc).

Windows binary and script is signed and trusted by default.

Current Absent Behavior

Please specify the current behavior (e.g. workaround, blockage, etc).

Windows binary is currently unsigned. It blocks PowerShell executions.

notice

Attachment

Please drag and drop the necessary data files (e.g. screenshot, logs, etc)
below.
hollowaykeanho commented 1 year ago

Appearently, there isn't a need to sign both of them so hooray. close this topic.