search

hollyjphilly / YourTube

A clone of YouTube built with React-Redux, Rails, AWS S3, and a Postgres database.
0 stars 0 forks source link

Schema Review #2

Closed danemauland closed 3 years ago

danemauland commented 3 years ago

Great work on your schema! There are only some minor issues/revisions:

-Review your uniqueness constraints and what you have indexed. For example, why con't you have two users with the same first name? Why is first name indexed? I imagine searches for other users would be based on username -Add indices as bullet points beneath the respective tables -As a bullet point, list which table each foreign key references, as well as the type of relationship Comment likes/video likes -Create these as polymorphic associations

hollyjphilly commented 3 years ago

-Fixed accidental uniqueness constraints, leaving indexing though I know it increases O(n) time in certain instances -Added associations & polymorphic associations