search

hollyjphilly / YourTube

A clone of YouTube built with React-Redux, Rails, AWS S3, and a Postgres database.
0 stars 0 forks source link

Backend Routes Review #4

Open danemauland opened 3 years ago

danemauland commented 3 years ago

Your first go at the backend routes shows you have a solid grasp on rails routing fundamentals great work! Some revisions:

-Give a brief description of each route--I imagine most of these would only need anywhere from a couple words to a full sentence, e.g. "log in user" -Deleting a user can be a bonus feature Views -Similar to my comments regarding your sample state, think about the minimum information you actually need here. Also, would you ever be making a get request to views, without needing to make a get request for other information? If not, can the view information just be returned with the other request? -When do you add a view to the database, and how is that done? If this happens as a side-effect to separate route. make sure you explain that. And in that case, it's good enough for now, but as a bonus, you could consider what might go wrong with that approach Comments -How will you update a comment if a user edits it?

hollyjphilly commented 3 years ago

-Added a brief description of each route -Moved deleting/updating user to bonus feature

-Updated sample state to only include likes and views numbers, as well as nested comments in video object

-When do you add a view to the database, and how is that done? This is on my list of questions to answer once I start figuring out the video playback.

Comments -I'm not adding editing/updating comment functionality.

danemauland commented 3 years ago

Review the name of this page for a typo Note subscribe routes as bonus Remove updating comments from your MVPs if you're not going to have that functionality.

Let's meet to discuss adding views, etc. to the database. This is something that you'll want thought-out before you start coding.