Change project directory environment variable

holman / dotfiles

@holman does dotfiles

http://zachholman.com/2010/08/dotfiles-are-meant-to-be-forked/

MIT License

7.3k stars 3.36k forks source link

Change project directory environment variable #246

Open defrank opened 8 years ago

defrank commented 8 years ago

Using $ZSH for the project root directory conflicts with zsh projects and plugins (e.g., oh-my-zsh). Change $ZSH -> $DOTFILES.

WIP: defrank/dotfiles#8/b

holman commented 8 years ago

This has come up a few times in the past; previously I've sided along the lines of being -1 because I didn't want to cause a lot of conflicts for existing users. Willing to reconsider, though; what are other people's thoughts on this?

jacobwgillespie commented 8 years ago

Based on the number of times this comes up, it seems worth it to rename. 😃 $DOTFILES is the first suggested alternate that sounds like it belongs to me.

+1 from me.

defrank commented 8 years ago

tag v2.0 for breaking backwards compatibility 👍

If this gets approved, then for anyone that relied on $ZSH in there addons:

git grep 'ZSH'

ErikMHummel commented 6 years ago

Another vote as my personal fork has this implemented.