fatal error when an image has been deleted

holman / spaceman-diff

diff images from the command line

MIT License

467 stars 13 forks source link

Closed jes5199 closed 8 years ago

jes5199 commented 8 years ago

I rmed an image from a repo and then ran git diff, and got:

expr: not a decimal number: '3,'
fatal: external diff died, stopping at test/images/gooder-flag.png

holman commented 8 years ago

Good call! I had dealt with this earlier but then added the headers, which it was failing on. Fixed.

jes5199 commented 8 years ago

:+1: that fixed it for me

lfilho commented 4 years ago

I'm running latest version as of this writing, installed via homebrew (macos).

Although there is a deleted filed in the staging area, I don't have the expr error line, and the stopping at file does exist.