search

holman / spark

▁▂▃▅▂▇ in your shell.
http://zachholman.com/spark/
MIT License
6.01k stars 290 forks source link

Add spark symlink in bin folder #78

Closed juanibiapina closed 9 years ago

juanibiapina commented 10 years ago

I would like to hear your thoughts on this.

Would you consider some sort of convention for binaries? In this case, I can use:

basher install holman/spark

Without a bin folder, both spark and test would be included in the path, since both are executable.

Another option would be to have only spark be an executable in the project root.

holman commented 10 years ago

Hm. Interesting thought, and it appeals to my everything-in-their-place part of my brain.

I'm kind of on the fence; part of what I like about spark is that it's pretty accessible, particularly for people who might be new to shell scripts (or even programming at all!). It's a little thing, but tucking it away in bin/ might make it a bit more opaque, or otherwise give the impression that what's going on in here is more complicated than it is.

Might be overthinking it, though. Would be curious on what other people think make the most sense here. (And if we move to bin/, we'll also need to update the README link and then probably add a test/ for the test files, too.)

juanibiapina commented 10 years ago

In the spirit of everything in its place, I don't like having the main executable and its tests in the same directory. Maybe separating the tests in a directory and leaving the spark executable where it is could help make it more clear. That way the project root would not have anything test related. On Nov 9, 2014 5:06 PM, "Zach Holman" notifications@github.com wrote:

Hm. Interesting thought, and it appeals to my everything-in-their-place part of my brain.

I'm kind of on the fence; part of what I like about spark is that it's pretty accessible, particularly for people who might be new to shell scripts (or even programming at all!). It's a little thing, but tucking it away in bin/ might make it a bit more opaque, or otherwise give the impression that what's going on in here is more complicated than it is.

Might be overthinking it, though. Would be curious on what other people think make the most sense here. (And if we move to bin/, we'll also need to update the README link and then probably add a test/ for the test files, too.)

— Reply to this email directly or view it on GitHub https://github.com/holman/spark/pull/78#issuecomment-62314766.

holman commented 9 years ago

I think I'm going to :-1: this; I like the discoverability of it right in the directory. Thanks for the idea, though!