search

holmari / gerritstats

Tool for creating statistics from a Gerrit repository
MIT License
193 stars 54 forks source link

Module not found after ./gerrit_stats.sh #24

Closed janekolszak closed 7 years ago

janekolszak commented 7 years ago

Hi! Great project, thank you so much for sharing!

I get some warnings when running npm install in GerritStats:

npm WARN redbox-react@1.4.2 requires a peer of react@^0.14.0 || ^15.0.0 but none was installed.
npm WARN redbox-react@1.4.2 requires a peer of react-dom@^0.14.0 || ^15.0.0 but none was installed.
npm WARN sass-loader@4.1.1 requires a peer of node-sass@^3.4.2 || ^4.0.0 but none was installed.

And then when running ./gerrit_stats.sh i get a looooot of Module not found:.

janekolszak commented 7 years ago

I had to install bunch of modules to make it work.

causten commented 7 years ago

How did you get past ... Module not found: Error: Cannot resolve module 'd3-svg-legend/no-extend'

janekolszak commented 7 years ago

Probably npm install d3-svg-legend

holmari commented 7 years ago

Really sorry that I don't have time to maintain this project, I'm no longer working with Gerrit on a daily basis for almost a year now. Any PRs to fix issues or building new features are very welcome!

causten commented 7 years ago

The newer version of d3-svg-legend does not have no-extend. I had to down level to 1.13 to get past that error npm install d3-svg-legend@1.13

That said, I builds fine now but the java pge does not load. Too bad, this tool looks great. I suspect this is a case of new versions of modules not being fully compatible with each other.
Console... TypeError: _this.props.history is undefined[Learn More] bundle.js:23556:8 GET http://localhost/~causten/out-html/bootstrap.css.map [HTTP/1.1 404 Not Found 18ms]

meehatpa commented 7 years ago

Same here, index page is empty. Would want to know versions of all modules needed to make it work. Can someone help?

meehatpa commented 7 years ago

FInally able to make it work after spending ~4 hours. Installed d3@3 and react-router@3.0.2 which solved last few issues

holmari commented 7 years ago

@guneshwor Could you make a PR?

meehatpa commented 7 years ago

Sure.

holmari commented 7 years ago

I took a bit of time just now to take a look at these issues. @janekolszak, @causten, why do you have to install particular versions of the packages manually? ./gradlew assemble should run the npm setup for you, and install all required packages in GerritStats/node_modules directory. Is that not working?

Meanwhile, I committed a package-lock.json file to master, which should also help resolving any dependency issues. Please try that out and let me know if it works.

causten commented 7 years ago

Thank you. I vote to close this issue as the problem is now fixed. If you are ever in Austin Texas, I'll buy you a drink.