search

holmari / gerritstats

Tool for creating statistics from a Gerrit repository
MIT License
193 stars 54 forks source link

Update for Java 11 and npm #48

Closed chrisinmtown closed 4 years ago

chrisinmtown commented 4 years ago

1) Revise use of classloader in CommandLineParser. In Java 11 the method getClass().getClassLoader() does not yield a URLClassLoader so the cast failed. Remove cast and revise to call method getResource() to fetch the MANIFEST.MF file.

2) Upgrade gradle wrapper to version 6.3. This works with Java 11.

3) Drop findbugs gradle plugin since it seems to be abandoned

4) Upgrade npm sass package to latest version like this: cd GerritStats && npm install node-sass@latest

holmari commented 4 years ago

Thanks @chrisinmtown ! I actually preferred the split commits, keeping them atomic would help with reverts if needed. But this works as well. Really appreciate putting out a PR for this.

chrisinmtown commented 4 years ago

Thanks @holmari for the merge. Did you test on Java 8 already?

Re multiple commits, I am still trying to learn the Github workflow. I think everyone has a different preference!

Also, I looked for a version number and/or release notes but didn't find anything here, am I blind?

chrisinmtown commented 4 years ago

I also failed to link this PR to the two open issues about build problems. Live and learn.