search

holmes-app / holmes-api

API for holmes website validation.
MIT License
17 stars 7 forks source link

Elastic Search for reviews, violations, etc #79

Closed marcelometal closed 10 years ago

heynemann commented 10 years ago

Some premises for this ticket:

a) The search MUST be done by a provider set in the configuration file (ElasticSearchProvider and NoExternalSearchProvider should be built-in with NoExternalSearchProvider being what we have today); b) Both notifying the index and retrieving data from the index MUST be done by this provider; c) Switching providers should be as simple as changing the config file; d) All the relevant search queries should be in the search provider, being forwarded from the Handler in the API.

scorphus commented 10 years ago

Support to ES version 0.90.12. Should support latest stable version instead -- namely, 1.1.1. There are some breaking changes as discussed in http://www.elasticsearch.org/guide/en/elasticsearch/reference/1.x/breaking-changes.html

scorphus commented 10 years ago

A violation's reviews could be ordered by URL instead of score.

scorphus commented 10 years ago

Ordering violation's reviews by completed_date DESC

scorphus commented 10 years ago

Investigating elasticsearch/elasticsearch#5853 and how to get around it.

scorphus commented 10 years ago

I'm dropping function_score in favor of sort. Ultimately, it won't be much different and perhaps even faster.