holmesal / shortwave

2 stars 0 forks source link

Every channel is unread (doesn't seem to be updating lastSeen) #149

Closed holmesal closed 10 years ago

holmesal commented 10 years ago

v0.1.19

For some reason, all of my channels are showing unread indicators. Opening the channels doesn't do anything to resolve this, and I can see from the firebase that nothing is being set in the lastSeen property.

When I click on the channel in the desktop app, I can see on the web that the correct time is being set: image

(console has /1000 to show seconds - easier to parse)

But my app still looks like this: 2014-08-21 20 48 09

holmesal commented 10 years ago

The following steps will set lastSeen and get rid of the unread notification:

  1. Click on the channel
  2. Send a message
  3. Go back to the channel list

Interesting, the following also sets lastSeen and gets rid of the notification:

  1. Send a message on desktop
  2. Observe the delicious bounce animation on the ios channel list
  3. Click on the channel
  4. Go back to the channel list
holmesal commented 10 years ago

So it seems to me that you might just not be setting lastSeen properly when the user views the channel.

Not sure what your condition for this is, but on desktop/web I somewhat naively just set it every time they click on the channel, and update it for every message that comes in while they're actively viewing the channel.

DogsForArms commented 10 years ago

I have been setting last seen == the last visible cell that appeared, i think it's good enough to mark all as read once you get on the page.

holmesal commented 10 years ago

:rocket:- alonso

On Mon, Aug 25, 2014 at 12:39 PM, Ethan Sherr notifications@github.com wrote:

Closed #149 via bae35b48dfd6ada5cface6285d9417275c43f08f.

Reply to this email directly or view it on GitHub: https://github.com/holmesal/shortwave/issues/149#event-156875477