search

holmgr / cargo-sweep

A cargo subcommand for cleaning up unused build files generated by Cargo
MIT License
694 stars 31 forks source link

Fingerprint atime #16

Closed Eh2406 closed 5 years ago

Eh2406 commented 5 years ago

This builds on and includes #14. As discussed in https://github.com/holmgr/cargo-sweep/issues/6#issuecomment-447918349, Cargo always reads the hash file in the fingerprint folder for the full transitive set of depended artifacts for every build. Thus the max atime in the fingerprint folder is the most reliable measure of witch artifacts are stale. And it is reliable enough to use with the -s argument.

Eh2406 commented 5 years ago

I know that it is hard to keep up with OSS with the holidays. Nonetheless, I would appreciate some response to my PRs. If my experiments for how a GC can work as a cargo subcommand are out of scope for this project I understand and will reach out to other projects. If I do not hear from you in the next week I will assume this is out of scope.

holmgr commented 5 years ago

Decided to stay clear of coding during the holidays to really relax for a while but have slowly started coming back to it, but I have a bit of a backlog of things to handle :P Your PR looks very good to me.

Eh2406 commented 5 years ago

Thanks for getting back to me. That is entirely reasonable, I hope it was relaxing!

holmgr commented 5 years ago

Oh, it certainly was, hopefully, you had a wonderful holiday yourself!