search

holmgr / cargo-sweep

A cargo subcommand for cleaning up unused build files generated by Cargo
MIT License
729 stars 31 forks source link

it is called cargo-sweep not hello #18

Closed Eh2406 closed 5 years ago

Eh2406 commented 5 years ago

I don't know if this is sufficient to make the next release easily installable, but I think it is a step in the correct direction. cc https://github.com/holmgr/cargo-sweep/issues/4#issuecomment-449103569, I think when this is working it will be possible to install without building from scratch with something like this. I can confirm that 0.3.0 does not support it, but I do not know if this is enough to get it working.

@epage any other advice for getting this set up or for testing that it is working correctly?

holmgr commented 5 years ago

Ah, I left placeholders, :P Good job @Eh2406! Lets see if it works now then :)

Eh2406 commented 5 years ago

I would love to see a 0.3.1 when you have a chance so we can test this out.

holmgr commented 5 years ago

Yes, I will do a new release today so we can see, we have a few new features etc, thanks to you! :)

Eh2406 commented 5 years ago

@jtgeibel did some testing at https://github.com/rust-lang/crates.io/pull/1602 and found that "I didn't try curl -LSfs https://japaric.github.io/trust/install.sh | sh -s -- --git holmgr/cargo-sweep because it looks like it expects precompiled binaries to be attached to the release on github."

I don't know how we have trust set up wrong, but it is not making the release correctly.

holmgr commented 5 years ago

Hmm, we will have to look into that. Not familiar with trust before, just tried to follow the instruction available but I must have made some mistakes. Will try to look into it on Sunday if I have time.

Eh2406 commented 5 years ago

Ya, I have never used trust ether. I wish I could be more help.

Eh2406 commented 5 years ago

The install script is definitely not working. https://travis-ci.org/Eh2406/cargo/jobs/484542914#L621-L631