search

holmgr / cargo-sweep

A cargo subcommand for cleaning up unused build files generated by Cargo
MIT License
729 stars 31 forks source link

the tags we are making do not start with v #21

Closed Eh2406 closed 5 years ago

Eh2406 commented 5 years ago

This was suggested on gitter.im/rust-lang/WG-CLI by @epage. This is another try to get eazy installing working, cc https://github.com/holmgr/cargo-sweep/pull/18. This should mean that future releases like you have made in the past will get picked up.

It is possible that adding a tag "v0.4.0" to the commit that is currently tagged "0.4.0" will get this working, or we could just release a "0.4.1" after this is merged, or we can wheate for the next feature to be added.

Eh2406 commented 5 years ago

looks like install won't work with non v anyway https://github.com/japaric/trust/blob/master/ci/install.sh#L36

This pr will not work. The next step is to make releases with a v at the front.

Eh2406 commented 5 years ago

I tried on my branch and I think just changing the tags will work!

Eh2406 commented 5 years ago

I guess we could, merge this. Then change https://github.com/holmgr/cargo-sweep/blob/master/ci/install.sh#L36 to not have the v and point peapal to our fork of the install script.

holmgr commented 5 years ago

I think I will just merge #22 and then use v in our versions from here on in

Eh2406 commented 5 years ago

It did correctly trigger a build!!! Unfortunately, looks like it errored https://travis-ci.com/holmgr/cargo-sweep/builds/99794261