search

holmgr / cargo-sweep

A cargo subcommand for cleaning up unused build files generated by Cargo
MIT License
693 stars 31 forks source link

--time option requires a value #38

Closed sourcefrog closed 4 years ago

sourcefrog commented 4 years ago

Remove help text incorrectly indicating that it might not

Eh2406 commented 4 years ago

What does it do currently if it is missing?

sourcefrog commented 4 years ago

With cargo-sweep 0.5.0 from crates.io:

mbp@cheery ~/src/conserve> cargo sweep -t
error: The argument '--time <days>' requires a value but none was supplied                                                                   

USAGE:
    cargo-sweep sweep <--stamp|--file|--time <days>|--installed|--toolchains <toolchains>|--maxsize <maxsize>>                               

For more information try --help
sourcefrog commented 4 years ago

Optional option-args are kind of a bad idea, anyhow, because they make the option grammar more ambiguous.

Eh2406 commented 4 years ago

Thanks!

I merged without noticing the CI failure. Can you submit a follow up that gets thing to build?

sourcefrog commented 4 years ago

Oops, sorry. Will do.

sourcefrog commented 4 years ago

39