holo-routing / holo

Holo is a suite of routing protocols designed to support high-scale and automation-driven networks.
MIT License
274 stars 17 forks source link

`hostname` seems not to be in `holod` configuration #20

Closed frederic-loui closed 4 months ago

frederic-loui commented 7 months ago

When using remote holi-cli on several nodes, the hostname is always set to holo.

❯ target/debug/holo-cli --address http://clab-ripv2-freertr-rt6:50051
holo# show running
!
interfaces interface lo
 type iana-if-type:ethernetCsmacd
 ipv4
!
interfaces interface eth1
 type iana-if-type:ethernetCsmacd
 ipv4
!
interfaces interface eth2
 type iana-if-type:ethernetCsmacd
 ipv4
!
routing control-plane-protocols control-plane-protocol ietf-rip:ripv2 main
 !
 rip interfaces interface lo
 !
 rip interfaces interface eth1
 !
 rip interfaces interface eth2
!
rwestphal commented 7 months ago

I agree. The current "hostname" command feels more like a gimmick than anything useful.

I believe the best course of action is to implement the 'ietf-system' module, which would provide us with the 'system hostname STRING' command. Then, the CLI should use the hostname from the running configuration in the prompt.