Rtnetlink version Upgrade

holo-routing / holo

Holo is a suite of routing protocols designed to support high-scale and automation-driven networks.

MIT License

274 stars 17 forks source link

Rtnetlink version Upgrade #30

Closed Paul-weqe closed 1 month ago

Paul-weqe commented 2 months ago

upgrade rtnetlink to latest version: 0.4.1. Still unstable
upgrade netlink-packet-route to version 0.19.
Introduce netlink-packet-utils. Some of the items we were previously using in netlink-packet-route are now only accessible via that library.

Majority of the changes have been made in the netlink.rs files that exist both in holo-routing and holo-interface.

There have been several changes on rtnetlink & netlink-packet-route and key files, functions and structs have also been moved in the library. The changes have been reflected in this commit.

The upgrade has been necessitated due to the need for the ability to edit mac addresses while creating an interface (on the vrrp branch)

github-actions[bot] commented 2 months ago

Test Results

    1 files ±0   15 suites ±0 0s :stopwatch: ±0s 376 tests ±0 374 :heavy_check_mark: ±0 2 :zzz: ±0 0 :x: ±0 380 runs ±0 378 :heavy_check_mark: ±0 2 :zzz: ±0 0 :x: ±0

Results for commit 0b2dd027. ± Comparison against base commit 754a2a35.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.42%. Comparing base (754a2a3) to head (0b2dd02). Report is 1 commits behind head on vrrp.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## vrrp #30 +/- ## ========================================== - Coverage 63.50% 63.42% -0.09% ========================================== Files 177 177 Lines 29643 29660 +17 ========================================== - Hits 18825 18812 -13 - Misses 10818 10848 +30 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Paul-weqe commented 1 month ago

@rwestphal your help is requested.

Linter is failing despite the line it says is failing does not exist on the branch (upgrade-rtnetlink). The line exists in vrrp branch where the change has also been made but it still fails.

Can we treat that as a false negative ?

Paul-weqe commented 1 month ago

@rwestphal opening in a few.