search

holo-routing / holo

Holo is a suite of routing protocols designed to support high-scale and automation-driven networks.
MIT License
274 stars 17 forks source link

Holo fails to detect YANG callback operations #9

Closed nrybowski closed 7 months ago

nrybowski commented 7 months ago

Hi! I'm currently playing around with Holo to add new features. Until now, I developed from ad9d2cf77ebb11159928242f1ffe09465cfaa384 with success but I faced an annoying issue while rebasing my commits on top of 663b2689f52c56c6a5c88fb2122831f0e33dda61. It seems that none of the YANG callback operations are detected while loading a simple OSPF configuration:

2024-04-05T04:37:09.664548Z ERROR missing callback operation=GetElement path=/ietf-routing:routing/control-plane-protocols/control-plane-protocol/ietf-bfd:bfd/summary/number-of-sessions
2024-04-05T04:37:09.664618Z ERROR missing callback operation=GetElement path=/ietf-routing:routing/control-plane-protocols/control-plane-protocol/ietf-bfd:bfd/summary/number-of-sessions-up
2024-04-05T04:37:09.664645Z ERROR missing callback operation=GetElement path=/ietf-routing:routing/control-plane-protocols/control-plane-protocol/ietf-bfd:bfd/summary/number-of-sessions-down
2024-04-05T04:37:09.664672Z ERROR missing callback operation=GetElement path=/ietf-routing:routing/control-plane-protocols/control-plane-protocol/ietf-bfd:bfd/summary/number-of-sessions-admin-down
[...]
2024-04-05T04:37:09.722841Z ERROR missing callback operation=Rpc path=/ietf-ospf:clear-database
2024-04-05T04:37:09.722895Z ERROR missing callback operation=Rpc path=/ietf-rip:clear-rip-route
2024-04-05T04:37:09.722941Z ERROR failed to validate northbound callbacks errors=1526

I tested 663b2689f52c56c6a5c88fb2122831f0e33dda61 without my commits and the same issue appears. It seems that 4403662d814abccc1f5755ae59206ebf905c12ac introduced this behavior, 12d69e931c4f6b4f2f4a373e0008eb88243ccaec being still functional.

Here is my rustc version:

$ rustc --version
rustc 1.76.0 (07dca489a 2024-02-04)

and I'm compiling with the nightly toolchain in debug mode.

Did I miss something?

rwestphal commented 7 months ago

@nrybowski Thanks for reporting this problem. The commit you mentioned indeed introduced that regression. It should be fixed on the master branch now. Thanks again!

nrybowski commented 7 months ago

@rwestphal I confirm that the issue is solved on master, thanks for your fast reaction!