search

holochain-in-action / peer-share

9 stars 5 forks source link

Review of InstallAgentApp #2

Closed NickT-78 closed 3 years ago

NickT-78 commented 3 years ago

Review on the common method InstallAgentApp to allow passing the agent key as a parameter.

Please review and test for I cannot test on my platform. Not to sure about the line 30 ... Buffer.from(agentKey);. Maybe it needs the 'u' trick like in the progenitor.rs

HedayatAbedijoo commented 3 years ago

@NickT-78 thanks for PR. I also refactor your change and finished unfinished part. Before merging to main branch, would you like to take another look.?

HedayatAbedijoo commented 3 years ago

this test setting is good enough to start with, later on for more complex scenario we might need to refactor it