holochain / clutter

Fully distributed twitter built on holochain
161 stars 22 forks source link

add likes, closes #2 #100

Closed science-girl closed 6 years ago

science-girl commented 6 years ago

As a user, I would like to mark posts I like with a red heart icon and later be able to click on a previously favourited item (filled red heart) and have it unfavourited (red heart outline).

science-girl commented 6 years ago

@bboyatwork thanks! I thought I had deleted that...I had the hashes printed so I could make sure the right ones were being stored. I can't seem them in my branch. Maybe someone else can confirm?

Connoropolous commented 6 years ago

reviewing now... sorry it took me a while

Connoropolous commented 6 years ago

I'm not seeing the list of meows again when I refresh... but it looks like that's an issue on develop branch too :s

science-girl commented 6 years ago

@Connoropolous I can't remember if the meows previously persisted on refresh or not. Looks like the refresh wipes out the redux store. Should we use redux-persist or redux-storage? Or is there another possibility?

Connoropolous commented 6 years ago

I'm sure they're there. They're just not being fetched when the page loads. The action already exists it just needs to be dispatched when the component mounts. That should be done as a bug fix branch from the main develop branch and a separate pr

On Tue, Jun 12, 2018, 8:25 PM Lindsey Woo notifications@github.com wrote:

@Connoropolous https://github.com/Connoropolous I can't remember if the meows previously persisted on refresh or not. Looks like the refresh wipes out the redux store. Should we use redux-persist or redux-storage? Or is there another possibility?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/holochain/clutter/pull/100#issuecomment-396775321, or mute the thread https://github.com/notifications/unsubscribe-auth/ABWAYbS-lbrNijm_33z1SDqDEpI5XeKpks5t8FvegaJpZM4Ugz72 .

science-girl commented 6 years ago

@Connoropolous created a new issue on the waffle board for it. https://waffle.io/holochain/org/cards/5b217e1643ca99001b96cdc7

Connoropolous commented 6 years ago

@science-girl so in theory, would this PR include showing on existing meows whether you liked them or not?

science-girl commented 6 years ago

Yes, this would be how a user would favourite tweets. There is another PR for clicking on a link to show all the tweets you have favourited.

zippy commented 6 years ago

Hey @Connoropolous @science-girl, I loaded this up, did a npm run build and I'm getting a weird result. In the UI I can add posts, and even click on the heart, but when I reload the UI, none of the posts appear. It's as if they aren't getting stored correctly to the chain.

I'd love to get this ticket completed and merged as part of this sprint. Can y'all tell me if I'm doing something wrong?

zippy commented 6 years ago

I see that this is not a problem with this branch but is a bug in the develop branch. I've added #103 to address this.