Closed science-girl closed 6 years ago
Hm, seems this was merged with only one approval.. ;) Looks good, but I would have asked to split these different concerns into different PRs. Not because it really is a problem with this set of features (which are all small enough to not render this PR super large) but more like an example of how to best use pull-requests etc..