holochain / holochain-client-js

A JavaScript client for the Holochain Conductor API
Other
258 stars 16 forks source link

Fix bad dir imports #244

Closed ThetaSinner closed 4 months ago

ThetaSinner commented 4 months ago

My IDE thought (wrongly) that because the project uses TypeScript, that dir imports are valid. They are not once the library is built and running as a JS dependency!

I've updated CI with a check that would have caught this mistake.

jost-s commented 4 months ago

Right, yes, with ES modules, importing the .js file is the universal way for JS and TS.