The custom Hash impl for EntryAspect was basing the hash only on the entry address found in the aspects entry header. This is not correct though as an entry could be created multiple times (either by the same author at different points in time - or by different authors) which would result in the same entry and entry hash but different headers (different provenance and/or timestamp).
In order to differentiate these different entry aspects they need to hash differently.
These changes include the whole header as well as the aspect type in the input for the hash calculation.
testing/benchmarking notes
( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )
followups
( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )
changelog
[ ] if this is a code change that effects some consumer (e.g. zome developers) of holochain core, then it has been added to our between-release changelog with the format
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)
documentation
[ ] this code has been documented according to our docs checklist
PR summary
The custom
Hashimpl forEntryAspectwas basing the hash only on the entry address found in the aspects entry header. This is not correct though as an entry could be created multiple times (either by the same author at different points in time - or by different authors) which would result in the same entry and entry hash but different headers (different provenance and/or timestamp).In order to differentiate these different entry aspects they need to hash differently.
These changes include the whole header as well as the aspect type in the input for the hash calculation.
testing/benchmarking notes
( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )
followups
( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )
changelog
documentation