holochain / holochain-rust

DEPRECATED. The Holochain framework implemented in rust with a redux style internal state-model.
GNU General Public License v3.0
1.12k stars 267 forks source link

await on join #2137

Closed freesig closed 4 years ago

freesig commented 4 years ago

PR summary

This awaits on the new connection future instead of just spawning it because otherwise the Lib3hToClient::HandleGetGossipingEntryList and Lib3hToClient::HandleGetAuthoringEntryList messages get sent and can be responded to before the join is complete. This leads to the responses to those messages being thrown away. Then the agents id's never actually get into the DHT.

testing/benchmarking notes

( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )

followups

( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )

changelog

- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)

documentation